Skip to content

Conversation

AyanSinhaMahapatra
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra commented May 18, 2023

See aboutcode-org/scancode.io#715 (comment)

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Looked for possible updates in documentation and added updates if applicable
  • Updated CHANGELOG.rst

@AyanSinhaMahapatra
Copy link
Member Author

@pombredanne this is ready to review! We can do a rc5 after this is merged.

Btw, this was already in the changelog from this commit: d264aec but it was not YAML yet

Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! we still need a few mini tests IMHO for a YAML, JSON and JSON-line outputs in formattedcode where we would have a few packages with such statements. I suggest an old npm (with a mapping), a new npm (with a single string as an expression) a Maven and PyPI with classifiers and license to have sample of the multiple use cases.

Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we can add other output tests later

@AyanSinhaMahapatra AyanSinhaMahapatra force-pushed the fix-extracted-license-statement branch from 6f7f8d0 to 3ce9efc Compare May 22, 2023 11:43
@AyanSinhaMahapatra
Copy link
Member Author

@pombredanne thanks, I've also added the tests. Merging!

@AyanSinhaMahapatra AyanSinhaMahapatra merged commit 232f442 into develop May 22, 2023
@AyanSinhaMahapatra AyanSinhaMahapatra deleted the fix-extracted-license-statement branch May 22, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants