Skip to content

Conversation

AyanSinhaMahapatra
Copy link
Member

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Looked for possible updates in documentation and added updates if applicable
  • Updated CHANGELOG.rst

Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Go for it!
You may want to run the release script once by tagging this in a fork and check how things work.

Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
@AyanSinhaMahapatra
Copy link
Member Author

We have a successful run for the build scripts at https://github.com/AyanSinhaMahapatra/scancode-toolkit/actions/runs/5050474341 from this branch, and tests are all green too! Merging this and tagging v32.0.0 right after 🚀

@AyanSinhaMahapatra AyanSinhaMahapatra merged commit f3086c5 into develop May 22, 2023
@AyanSinhaMahapatra AyanSinhaMahapatra deleted the release-prep-v32 branch May 22, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants