Skip to content

Fix licenses data in summary plugin #3430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 29, 2023
Merged

Fix licenses data in summary plugin #3430

merged 2 commits into from
Jun 29, 2023

Conversation

AyanSinhaMahapatra
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra commented Jun 20, 2023 •
edited
Loading

Changes:

  1. The top level license detection is now sorted.
  2. License tallies are now computed from license detections.
  3. Fix a bug effecting the count of files with no license detected.

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Looked for possible updates in documentation and added updates if applicable
  • Updated CHANGELOG.rst

@AyanSinhaMahapatra
Sort top level license detections
3706744 
This makes the top level license detection sorted, first in
alphabetical order, then in descending order of detection_count
and then on the identifier/UUID. Also regens tests for the same.

Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
@AyanSinhaMahapatra AyanSinhaMahapatra marked this pull request as draft June 20, 2023 22:13
@AyanSinhaMahapatra
Fix license tallies to reflect license detections
e367fa2 
Fix license tallies to be keyed by license expressions for each
license detection, instead of the detected_license_expression
for a file. Also take into account package license detections.

Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
@AyanSinhaMahapatra AyanSinhaMahapatra marked this pull request as ready for review June 22, 2023 11:06
pombredanne
pombredanne approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! you may want to check your usage of constants inside functions for improved readability (e.g., use less of these ;) )

@pombredanne pombredanne merged commit dc86a47 into develop Jun 29, 2023
@pombredanne pombredanne deleted the fix-summary-license branch June 29, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pombredanne pombredanne pombredanne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AyanSinhaMahapatra @pombredanne