Skip to content

Conversation

@AyanSinhaMahapatra
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra commented Jun 23, 2023

Reference: aboutcode-org/scancode-licensedb#37

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled πŸ“‘ and links the original issue above πŸ”—
  • Tests pass -- look for a green checkbox βœ”οΈ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts πŸ“
  • Looked for possible updates in documentation and added updates if applicable
  • Updated CHANGELOG.rst

@AyanSinhaMahapatra AyanSinhaMahapatra changed the title Add licenses/exceptions from SPDX license list 3.21 Update licenses and rules Jun 23, 2023
@AyanSinhaMahapatra AyanSinhaMahapatra marked this pull request as draft June 23, 2023 13:53
Copy link
Member Author

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some comments/questions which I had while adding these, adding these here to help your review @DennisClark @pombredanne
I've added the owner/category to the best of my knowledge, but it could be wrong too as I was not sure for some of these, so keep an eye out for those.

@AyanSinhaMahapatra AyanSinhaMahapatra marked this pull request as ready for review June 23, 2023 15:17
Copy link
Member

@DennisClark DennisClark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a few minor changes suggested but not mandatory.

Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pombredanne pombredanne merged commit 0d5d2fd into develop Jun 29, 2023
@pombredanne pombredanne deleted the update-license-rules branch June 29, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants