Skip to content

Conversation

jdaguil
Copy link
Contributor

@jdaguil jdaguil commented Aug 31, 2015

writing data.json file into the assets folder instead of into the template

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdaguil can you elaborate why you updated the logic here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pombredanne The change was to make the check for '' more explicit.

BEFORE:


tgt_dirs = get_html_app_files_dirs(output_file)
if not tgt_dirs:
    raise HtmlAppAssetCopyWarning()         # not clear warning from stdout

AFTER:


if is_stdout(output_file):
    raise HtmlAppAssetCopyWarning()
tgt_dirs = get_html_app_files_dirs(output_file)         # output valid, no need to check

@pombredanne pombredanne merged commit c354953 into develop Sep 18, 2015
@pombredanne pombredanne deleted the issue_38_separate_json branch October 14, 2015 15:17
AyanSinhaMahapatra pushed a commit that referenced this pull request Apr 4, 2023
Properly check for existance of thirdparty dir
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants