Skip to content

Conversation

aayushkdev
Copy link
Collaborator

@aayushkdev aayushkdev commented Sep 6, 2025

Reference #1840

  • Refreshing now keeps you on the same folder/files
  • Moved redundant code into functions to reduce code duplication in resource_tree

@tdruez
Copy link
Contributor

tdruez commented Sep 8, 2025

@aayushkdev I generally work fine but there's an issue:
I cannot open a link of the current path, neither with the links of the table, and open into a new tab/new window. Same issue if I want to copy one of those links.

I think the href="#" should actually contain the link.

On a minor note, any reason to use "is-family-monospace"? I think the UI looks better without this class.

@aayushkdev
Copy link
Collaborator Author

aayushkdev commented Sep 8, 2025

@aayushkdev I generally work fine but there's an issue: I cannot open a link of the current path, neither with the links of the table, and open into a new tab/new window. Same issue if I want to copy one of those links.

I think the href="#" should actually contain the link.

On a minor note, any reason to use "is-family-monospace"? I think the UI looks better without this class.

Using is-family-monospace was more of a personal preference also I also wanted the breadcrumbs to look distinct from the table, but you’re right, it’s better if they use the usual font, so I’ve removed it.

@tdruez tdruez merged commit 473c6fe into aboutcode-org:main Sep 8, 2025
11 checks passed
@tdruez
Copy link
Contributor

tdruez commented Sep 8, 2025

@aayushkdev It looks and works great! 🚀

Since the next item on the list is quite small, it would be a good time to document a bit more each JS function to make the code easier to read and wok on.

@aayushkdev aayushkdev deleted the track-current-url branch September 8, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants