Skip to content

Conversation

@SKADE2303
Copy link
Collaborator

This PR is responsible for translating the module publication to different languages. Currently only 'Hindi' language is supported but other languages can be added as required.

Testing instructions (if applicable)

  1. Run 'make dev' to load changes
  2. Change language_preference to Hindi in my_preferences Tab
  3. Go to publication tab to see translated web page.

@github-actions github-actions bot added Language: PHP PR or issue that update PHP code Language: Javascript PR or issue that update Javascript code Module: publication PR or issue related to the publication module labels Oct 17, 2025
@SKADE2303 SKADE2303 added Multilingual Any tasks related to making LORIS multilingual Event: GSOC PR or issue accepted for Google Summer of Code Language: Javascript PR or issue that update Javascript code Module: publication PR or issue related to the publication module and removed Language: PHP PR or issue that update PHP code Language: Javascript PR or issue that update Javascript code Module: publication PR or issue related to the publication module labels Oct 17, 2025
@SKADE2303 SKADE2303 marked this pull request as ready for review October 21, 2025 17:44
@racostas
Copy link
Contributor

racostas commented Nov 3, 2025

@SKADE2303, please fix conflicts.

@christinerogers

@racostas racostas added the State: Needs work PR awaiting additional work by the author to proceed label Nov 3, 2025
@github-actions github-actions bot added the Language: PHP PR or issue that update PHP code label Nov 3, 2025
Copy link
Contributor

@racostas racostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This filters are now not working after the PR
image

Missing translations:
image

Missing translations:
image

@racostas racostas self-requested a review November 4, 2025 05:41
Copy link
Contributor

@racostas racostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This filters are broken after this PR
image

Missing translatons
image

image image

Comment on lines -202 to 207

publication: modules/publication/locale/ja/LC_MESSAGES/publication.mo
publication:
msgfmt -o modules/publication/locale/hi/LC_MESSAGES/publication.mo modules/publication/locale/hi/LC_MESSAGES/publication.po
npx i18next-conv -l hi -s modules/publication/locale/hi/LC_MESSAGES/publication.po -t modules/publication/locale/hi/LC_MESSAGES/publication.json
target=publication npm run compile
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the difference between this lines and 151-152 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Event: GSOC PR or issue accepted for Google Summer of Code Language: Javascript PR or issue that update Javascript code Language: PHP PR or issue that update PHP code Module: publication PR or issue related to the publication module Multilingual Any tasks related to making LORIS multilingual State: Needs work PR awaiting additional work by the author to proceed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants