Skip to content

[imaging_browser] Translate imaging browser #9989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

[imaging_browser] Translate imaging browser #9989

wants to merge 11 commits into from

Conversation

@SKADE2303
Copy link
Collaborator

@SKADE2303 SKADE2303 commented Aug 29, 2025 •
edited
Loading

This PR is responsible for translating the module imaging_browser to different languages. Currently only 'Hindi' language is supported but other languages can be added as required.

Testing instructions (if applicable)

  1. Run 'make dev' to load changes
  2. Change language_preference to Hindi in my_preferences Tab
  3. Go to imaging_browser tab to see translated web page.

@github-actions github-actions bot added Language: Javascript PR or issue that update Javascript code Module: imaging_browser PR or issue related to imaging_browser module labels Aug 29, 2025
@SKADE2303 SKADE2303 added Multilingual Any tasks related to making LORIS multilingual Event: GSOC PR or issue accepted for Google Summer of Code labels Aug 29, 2025
driusan
driusan requested changes Sep 2, 2025
View reviewed changes
modules/imaging_browser/locale/imaging_browser.pot Outdated
msgid "Pending New"
msgstr ""

msgid "Entity Type"
Copy link
Collaborator

@driusan driusan Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I mentioned on a different module's PR that this should be in the loris namespace

modules/imaging_browser/locale/imaging_browser.pot
msgid "Links"
msgstr ""

msgid "SessionID"
Copy link
Collaborator

@driusan driusan Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this turning up that's user facing? (cc @cmadjar)

modules/imaging_browser/locale/imaging_browser.pot Outdated
msgid "all types"
msgstr ""

msgid "NEW"
Copy link
Collaborator

@driusan driusan Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"NEW" is in the loris namespace.

modules/imaging_browser/locale/imaging_browser.pot
msgstr ""

msgid "Pass"
msgstr ""
Copy link
Collaborator

@driusan driusan Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmadjar @ridz1208 Are pass/fail/selected common LORIS terms across modules or imaging_browser specific?

driusan
driusan reviewed Sep 2, 2025
View reviewed changes
modules/imaging_browser/locale/imaging_browser.pot Outdated
msgid "Header Info"
msgstr ""

msgid "Selected"
Copy link
Collaborator

@driusan driusan Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also make sure "Selected" (uppercase) is next to "selected" (lowercase) in the .pot file to make it easier to translate?

@driusan
Copy link
Collaborator

driusan commented Sep 2, 2025

I just tried testing this by adding Japanese translations and the "viewSession" page isn't getting translated for me.

It looks like InfoPanel.jsx is marked up, the strings are in the .pot/.po files, and I added the resource bundle in imagingBrowserIndex.js.

Is there anything else I need to change to add a new language for this module?

@racostas racostas added the State: Needs work PR awaiting additional work by the author to proceed label Sep 3, 2025
@racostas
Copy link
Contributor

racostas commented Sep 26, 2025

Hi @SKADE2303 , this one have conflicts. Please rebase.

@racostas racostas added the State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) label Sep 29, 2025
@racostas
Copy link
Contributor

racostas commented Sep 30, 2025

Is this one ready to be re-reviewed ?
Also the unrelated text failing are fixed already. Please relaunch the tests.

@racostas
Copy link
Contributor

racostas commented Oct 6, 2025

Test still failing here. Please re-launch / fix.

@SKADE2303 SKADE2303 force-pushed the TranslateImagingBrowser branch from 219082b to 4202fc8 Compare October 8, 2025 12:42
@racostas
Copy link
Contributor

racostas commented Oct 20, 2025

Hi @SKADE2303 there are still unsolved comments here. Also please rebase and solve conflicts. Thanks.

@christinerogers , @driusan

@SKADE2303 SKADE2303 force-pushed the TranslateImagingBrowser branch from 356bab1 to b5e14d1 Compare October 21, 2025 19:11
@SKADE2303 SKADE2303 removed State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) State: Needs work PR awaiting additional work by the author to proceed labels Oct 21, 2025
@SKADE2303 SKADE2303 force-pushed the TranslateImagingBrowser branch from 60fe084 to 0d65664 Compare October 29, 2025 20:43
@racostas racostas mentioned this pull request Oct 31, 2025
Merged
@racostas
Copy link
Contributor

racostas commented Nov 3, 2025

@SKADE2303 please fix conflicts.

@christinerogers

@racostas racostas added the State: Needs work PR awaiting additional work by the author to proceed label Nov 3, 2025
@SKADE2303 SKADE2303 force-pushed the TranslateImagingBrowser branch from c8ce494 to 0d65664 Compare November 3, 2025 20:20
@SKADE2303 SKADE2303 removed the State: Needs work PR awaiting additional work by the author to proceed label Nov 3, 2025
@racostas racostas self-requested a review November 3, 2025 21:27
racostas
racostas requested changes Nov 3, 2025
View reviewed changes
Copy link
Contributor

@racostas racostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • After this PR the links to the detailed view are broken (Please take look and fix) :
image
  • Some words yet untranslated:
image image

@racostas racostas added the State: Needs work PR awaiting additional work by the author to proceed label Nov 3, 2025
@racostas
Copy link
Contributor

racostas commented Nov 3, 2025

^ @christinerogers , @driusan

@SKADE2303 SKADE2303 force-pushed the TranslateImagingBrowser branch from d7fe927 to 54cae0c Compare November 4, 2025 13:54
@github-actions github-actions bot added the Language: PHP PR or issue that update PHP code label Nov 4, 2025
@SKADE2303 SKADE2303 force-pushed the TranslateImagingBrowser branch from 142625c to 169b275 Compare November 4, 2025 16:55
@SKADE2303 SKADE2303 removed the State: Needs work PR awaiting additional work by the author to proceed label Nov 4, 2025
racostas
racostas requested changes Nov 6, 2025
View reviewed changes
Copy link
Contributor

@racostas racostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Links are now working but in the detailed view not much seems to be translated:
image

This still don't appear translated during my test:
image

Same here:

locale/hi/LC_MESSAGES/loris.po Outdated

#: modules/candidate_list/php/module.class.inc:76
#: modules/new_profile/php/module.class.inc:50
#: modules/_profile/php/module.class.inc:50
Copy link
Contributor

@racostas racostas Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of this change ?

locale/loris.pot
Comment on lines 283 to 312
msgid "NEW"
msgstr ""

msgid "New"
msgstr "नया"

Copy link
Contributor

@racostas racostas Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the template file .pot should not have "translations". It's the template for all languages.

@racostas racostas added the State: Needs work PR awaiting additional work by the author to proceed label Nov 6, 2025
@SKADE2303 SKADE2303 force-pushed the TranslateImagingBrowser branch from bdaa134 to 95e9fe6 Compare November 6, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@driusan driusan driusan requested changes

@racostas racostas racostas requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@racostas racostas

@SKADE2303 SKADE2303

Labels

Event: GSOC PR or issue accepted for Google Summer of Code Language: Javascript PR or issue that update Javascript code Language: PHP PR or issue that update PHP code Module: imaging_browser PR or issue related to imaging_browser module Multilingual Any tasks related to making LORIS multilingual State: Needs work PR awaiting additional work by the author to proceed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SKADE2303 @driusan @racostas