fix: reuse Capybara chrome instance for lighthouse audits #616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukeify
approved these changes
Aug 22, 2025
G-Rath
requested review from
JacobBriggsAckama,
eoinkelly,
halles,
hmaddocks,
hopkincame,
joshmcarthur,
lukeify and
robotdana
JacobBriggsAckama
approved these changes
Aug 24, 2025
joshmcarthur
approved these changes
Oct 31, 2025
G-Rath
force-pushed
the
G-Rath-patch-1
branch
from
363f6c4 to
899624d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we actually spin up a whole new instance of Chrome when running lighthouse tests which besides being costly also means that none of our presetup work such as logging users in happens 😬