Skip to content

Fix for empty error objects in response breaking extraction of domain validation types #5008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 6, 2025
Merged

Fix for empty error objects in response breaking extraction of domain validation types #5008

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b0ca443
Fix for empty error objects in response breaking extraction of domain…
cjwalsh Feb 21, 2024
0f7ecad
Merge pull request #6409 from acmesh-official/dev
Neilpang Jun 25, 2025
d6eca62
Merge pull request #6411 from acmesh-official/dev
Neilpang Jun 25, 2025
02cb476
Merge pull request #6412 from acmesh-official/dev
Neilpang Jun 25, 2025
b64c57f
Merge pull request #6414 from acmesh-official/dev
Neilpang Jun 25, 2025
2402f46
Merge pull request #6416 from acmesh-official/dev
Neilpang Jun 25, 2025
52e051b
Merge pull request #6417 from acmesh-official/dev
Neilpang Jun 25, 2025
49866b6
Merge branch 'dev' into patch-1
cjwalsh Aug 3, 2025
e391301
Merge branch 'acmesh-official:master' into patch-1
cjwalsh Aug 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions acme.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4762,7 +4762,8 @@ $_authorizations_map"
_debug keyauthorization "$keyauthorization"
fi

entry="$(echo "$response" | _egrep_o '[^\{]*"type":"'$vtype'"[^\}]*')"
# Fix for empty error objects in response which mess up the original code, adapted from fix suggested here: https://github.com/acmesh-official/acme.sh/issues/4933#issuecomment-1870499018
entry="$(echo "$response" | sed s/'"error":{}'/'"error":null'/ | _egrep_o '[^\{]*"type":"'$vtype'"[^\}]*')"
_debug entry "$entry"

if [ -z "$keyauthorization" -a -z "$entry" ]; then
Expand Down Expand Up @@ -6351,7 +6352,8 @@ _deactivate() {
fi
_debug "Trigger validation."
vtype="$(_getIdType "$_d_domain")"
entry="$(echo "$response" | _egrep_o '[^\{]*"type":"'$vtype'"[^\}]*')"
# Fix for empty error objects in response which mess up the original code, adapted from fix suggested here: https://github.com/acmesh-official/acme.sh/issues/4933#issuecomment-1870499018
entry="$(echo "$response" | sed s/'"error":{}'/'"error":null'/ | _egrep_o '[^\{]*"type":"'$vtype'"[^\}]*')"
_debug entry "$entry"
if [ -z "$entry" ]; then
_err "$d: Cannot get domain token"
Expand Down
Loading