Skip to content

Conversation

@AnTheMaker
Copy link
Contributor

Nanelo Team- and Workspace-specific API keys require the "domain" parameter to be set containing the DNS zone name (unlike the Domain-specific API keys). So I've added a function to detect the root DNS zone and set the required parameter as described here: https://github.com/acmesh-official/acme.sh/wiki/DNS-API-Dev-Guide#3-detect-which-part-is-your-root-zone

Nanelo Team- and Workspace-specific API keys require the "domain" parameter to be set containing the DNS zone name (unlike the Domain-specific API keys).
So I've added a function to detect the root DNS zone and set the required parameter as described here: https://github.com/acmesh-official/acme.sh/wiki/DNS-API-Dev-Guide#3-detect-which-part-is-your-root-zone
@github-actions
Copy link

github-actions bot commented Sep 7, 2025

Welcome
READ ME !!!!!
Read me !!!!!!
First thing: don't send PR to the master branch, please send to the dev branch instead.
Please read the DNS API Dev Guide.
You MUST pass the DNS-API-Test.
Then reply on this message, otherwise, your code will not be reviewed or merged.
Please also make sure to add/update the usage here: https://github.com/acmesh-official/acme.sh/wiki/dnsapi2
注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

@AnTheMaker
Copy link
Contributor Author

This addresses #4519 (comment). The fix seems to work fine, I've tested it locally and all CI checks have passed as well.

@Neilpang
Copy link
Member

Neilpang commented Sep 7, 2025

@AnTheMaker
Copy link
Contributor Author

I ran the DNS test action and it seems to work fine for every OS, except for some weird error with "clearlinux", which I think is unrelated to my changes. See: https://github.com/AnTheMaker/acme.sh/actions/runs/17561923899/job/49880133609
Can you help @Neilpang?

@AnTheMaker
Copy link
Contributor Author

Okay, so I have tried running the Check DNS action multiple times now, and it always fails at the clearlinux test step with the following issue:

[...]
#5 1.972 Error: Failed to retrieve 43630 MoM manifest
#5 1.972 Error: Cannot load official manifest MoM for version 43630
[...]
clearlinux:latest [FAIL]
[Tue Oct 14 15:57:47 UTC 2025] Failed: clearlinux:latest

More details: https://github.com/AnTheMaker/acme.sh/actions/runs/18498830642/job/52719426807

I've created an issue about this: #6568

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants