-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
[Important DNS Provider Update] Support Nanelo DNS Team- & Workspace-specific API keys #6504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Nanelo Team- and Workspace-specific API keys require the "domain" parameter to be set containing the DNS zone name (unlike the Domain-specific API keys). So I've added a function to detect the root DNS zone and set the required parameter as described here: https://github.com/acmesh-official/acme.sh/wiki/DNS-API-Dev-Guide#3-detect-which-part-is-your-root-zone
|
Welcome |
using shfmt to format the code
|
This addresses #4519 (comment). The fix seems to work fine, I've tested it locally and all CI checks have passed as well. |
|
I ran the DNS test action and it seems to work fine for every OS, except for some weird error with "clearlinux", which I think is unrelated to my changes. See: https://github.com/AnTheMaker/acme.sh/actions/runs/17561923899/job/49880133609 |
|
Okay, so I have tried running the Check DNS action multiple times now, and it always fails at the More details: https://github.com/AnTheMaker/acme.sh/actions/runs/18498830642/job/52719426807 I've created an issue about this: #6568 |
Nanelo Team- and Workspace-specific API keys require the "domain" parameter to be set containing the DNS zone name (unlike the Domain-specific API keys). So I've added a function to detect the root DNS zone and set the required parameter as described here: https://github.com/acmesh-official/acme.sh/wiki/DNS-API-Dev-Guide#3-detect-which-part-is-your-root-zone