feat: Add simple Hypercore Depositor handler #1181
Closed
+108
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nicholaspai <[email protected]>
Signed-off-by: nicholaspai <[email protected]>
Signed-off-by: nicholaspai <[email protected]>
Signed-off-by: nicholaspai <[email protected]>
Signed-off-by: nicholaspai <[email protected]>
Signed-off-by: nicholaspai <[email protected]>
bmzig
previously approved these changes
Nov 17, 2025
Signed-off-by: nicholaspai <[email protected]>
bmzig
previously approved these changes
Nov 18, 2025
mrice32
reviewed
Nov 18, 2025
| * @param amount The amount of tokens on HyperEVM to deposit. | ||
| * @param user The address of the user on Hypercore to send the tokens to. | ||
| */ | ||
| function depositToHypercore(address token, uint256 amount, address user) external nonReentrant { |
Contributor
There was a problem hiding this comment.
This assumes that the tokens are dropped on the contract atomically, right?
What are the downsides of doing a transferFrom from msg.sender to pull the tokens in?
Member
Author
There was a problem hiding this comment.
that's a great call, I overlooked this flow. We definitely should pull funds from the msg.sender in depositToHypercore, unlike in handleAcrossV3Message
Signed-off-by: nicholaspai <[email protected]>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative to the MulticallHandler designed to support permissioned accounts to deposit ERC20's from hyperevm into an end user's hypercore account
Signed-off-by: nicholaspai [email protected]