fix esp32spi_aio_post.py -- remove bytes() #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I’ll test tonight. I don’t have my board with me at the moment. |
Collaborator
makermelissa
left a comment
makermelissa
left a comment
There was a problem hiding this comment.
It tested fine, but I'm wondering if we should make the PyPortal parameters the default?
makermelissa
approved these changes
Mar 16, 2019
Collaborator
makermelissa
left a comment
makermelissa
left a comment
There was a problem hiding this comment.
Actually I'm going to approve it and leave it up to you about which ones to make the default. I suppose probably leave it like it is so it matches.
Contributor
Author
|
@makermelissa I left it as is for now since the guides that use it tell the user to change it for PyPortal. |
Member
|
thanks folks! |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Mar 23, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_DRV2605 to 1.0.2 from 1.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_DRV2605#14 from caternuson/iss13 Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 1.3.5 from 1.3.4: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#30 from jerryneedell/jerryn_aio_post Updating https://github.com/adafruit/Adafruit_CircuitPython_GPS to 3.2.2 from 3.2.1: > Merge pull request adafruit/Adafruit_CircuitPython_GPS#16 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_IS31FL3731 to 2.3.1 from 2.3.0: > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3731#14 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_RA8875 to 1.0.5 from 1.0.4: > Merge pull request adafruit/Adafruit_CircuitPython_RA8875#8 from makermelissa/master > Merge pull request adafruit/Adafruit_CircuitPython_RA8875#7 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_TPA2016, Adafruit_CircuitPython_Display_Button, Adafruit_CircuitPython_Display_Shapes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove use of bytes() for the header strings