Fixed GPS I2C issue on Feather M4 Express #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryneedell
approved these changes
Feb 24, 2019
Contributor
jerryneedell
left a comment
jerryneedell
left a comment
There was a problem hiding this comment.
looks good -- tested on grand_central
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Feb 25, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP_ATcontrol to 0.2.3 from 0.2.2: > Merge pull request adafruit/Adafruit_CircuitPython_ESP_ATcontrol#27 from jerryneedell/jerryn_scan > Merge pull request adafruit/Adafruit_CircuitPython_ESP_ATcontrol#26 from jerryneedell/jerryn_secrets > Merge pull request adafruit/Adafruit_CircuitPython_ESP_ATcontrol#25 from dhalbert/ujson-to-json Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 1.2.2 from 1.2.1: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#12 from ladyada/master Updating https://github.com/adafruit/Adafruit_CircuitPython_FeatherWing to 1.7.2 from 1.7.1: > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#34 from makermelissa/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the GPS FeatherWing does not use I2C, but it was being initialized by shared, I went ahead and removed the import of shared and just init the UART stuff in the GPS FeatherWing helper. See #33 for more info.