Skip to content

Typing fixes #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 9, 2024
Merged

Typing fixes #35

merged 9 commits into from
Feb 9, 2024

Conversation

@justmobilize
Copy link
Contributor

In this update:

  1. Run isort to organize imports
  2. When TYPE_CHECKING import types from circuitpython-stubs
  3. define _FakeSSLContext in socket.py to simplify typing in other libraries

@justmobilize justmobilize marked this pull request as ready for review February 9, 2024 17:18
@justmobilize justmobilize mentioned this pull request Feb 9, 2024
Closed
dhalbert
dhalbert reviewed Feb 9, 2024
View reviewed changes
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that you added the imports, can you actually remove some of the double-quotes around typenames, like "rgbmatrix.RGBMatrix" -> rgbmatrix.RGBMatrix? Or is that still not possible because these are not in CPython?

@justmobilize
Copy link
Contributor Author

@dhalbert I removed a random selection and didn't get any additional errors... So looks like we should. Would you want that in this PR or a follow up?

@dhalbert
Copy link
Contributor

dhalbert commented Feb 9, 2024

Go ahead and do it in this one.

@justmobilize
Copy link
Contributor Author

@dhalbert looks like we can't. Since it's not defined except for typing it fails install (see the checks)

@justmobilize
Copy link
Contributor Author

link here: https://github.com/adafruit/Adafruit_CircuitPython_Typing/actions/runs/7848800701/job/21420726625?pr=35

@justmobilize justmobilize requested a review from dhalbert February 9, 2024 19:50
dhalbert
dhalbert approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, this looks good! I'll release so you can use for the libraries that depend on these fixes.

@dhalbert dhalbert merged commit 45263eb into adafruit:main Feb 9, 2024
@justmobilize justmobilize mentioned this pull request Feb 9, 2024
Merged
@dhalbert dhalbert mentioned this pull request Feb 13, 2024
Merged
@dhalbert dhalbert mentioned this pull request Mar 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@justmobilize @dhalbert