Fix SAMD toolsDependencies to match platform.txt #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toolsDependencies (what tools to download) must match tools and versions required by platform.txt
Fix SAMD toolsDependencies to match platform.txt
Member
|
@hathach this should be testable by CI? |
|
This fixes my issue with uploading using |
hathach
approved these changes
Feb 26, 2020
Member
There was a problem hiding this comment.
changes is similar to Arduino SAMD official latest package at 1.8.5
https://downloads.arduino.cc/packages/package_index.json
Tested local, it is (pretty) safe to merge.
@ladyada CI won't be able to test this, since this PR only apply to the next release after merged. We could bump up samd release if there is pending changes to test with. I did a local test and it compiles and upload just well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes: bpt.ini
Fix: toolsDependencies (tools to download) must match tools and versions required by associated platform.txt
This pr only addresses future version builds to package_adafruit_index.json for SAMD toolsDependencies... as long as platform.txt versions are the same (please keep in sync).
Current and several past versions are still incorrect because their toolsDependencies are out of sync with their respective platform.txt.