fix: Give a warning when using Safari for CLI login #2500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The message itself I think is fine. I get the hesitation on such warnings, and open to the idea that the a temp fix like this isn't worth the trouble. Relatively small fraction of projects use site auth. Relatively small fraction of users use safari on desktop. It's entirely plausible this fix has an audience of one person (me). Given that, I'd be supportive of holding off and seeing if we get more reports of the problem before we do anything. |
tripodsan
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#2498
Temporary Fix
Until Safari is supported, the suggestion from @shsteimer was to give a warning to developers, so they don't have to debug themselves.
Not sure how I feel about such warnings. On one hand I understand how they could be useful, but at the same time they require the developer to upgrade the CLI to see it.