Skip to content

Conversation

@clansty
Copy link
Contributor

@clansty clansty commented Feb 15, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • All tests are passing

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

I found it's unable to listen 'scroll' event using this.$refs[...].addEventListener(...) in mounted() when I am using Electron 11.2.3 and Vue 2.6.12.

So I moved the function to a function called containerScroll(e) and use @scroll to listen the scroll event, it finally works

@antoine92190
Copy link
Collaborator

Thanks! Will test that soon

@antoine92190 antoine92190 merged commit 8fa5447 into advanced-chat:master Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants