Skip to content

Error handling for cell row/col smaller than 1 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2022
Merged

Error handling for cell row/col smaller than 1 #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions source/lib/cell/cell.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,14 @@ const Comment = require('../classes/comment');
// §18.3.1.4 c (Cell)
class Cell {
/**
* Create an Excel Cell
* @private
* @param {Number} row Row of cell.
* @param {Number} col Column of cell
*/
* Create an Excel Cell
* @private
* @param {Number} row Row of cell.
* @param {Number} col Column of cell
*/
constructor(row, col) {
if (row <= 0) throw 'Row parameter must not be zero or negative.';
if (col <= 0) throw 'Col parameter must not be zero or negative.';
this.r = `${utils.getExcelAlpha(col)}${row}`; // 'r' attribute
this.s = 0; // 's' attribute refering to style index
this.t = null; // 't' attribute stating Cell data type - §18.18.11 ST_CellType (Cell Type)
Expand Down Expand Up @@ -77,4 +79,3 @@ class Cell {
}

module.exports = Cell;