Skip to content

Conversation

@odsod
Copy link
Contributor

@odsod odsod commented Nov 10, 2025

🍱 Types of changes

What types of changes does your code introduce to AEP? Put an x in the boxes
that apply

  • Enhancement
  • New proposal
  • Migrated from google.aip.dev
  • Chore / Quick Fix

If/when accepted, I'll follow up with an update to https://github.com/aep-dev/api-linter/blob/main/rules/aep0191/proto_version.go

@odsod odsod requested a review from a team as a code owner November 10, 2025 11:11
## Syntax

APIs defined in protocol buffers **must** use `proto3` syntax.
APIs defined in protocol buffers **must** use `proto3` syntax or one of the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also add all fields should be marked optional? Unless that's in a different AEP already.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@toumorokoshi Do you mean when using proto3 syntax all fields should be marked optional? When using 2023 and above, it's all optional by default, so no optional directives needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can add another paragraph under the first one saying:

When using `proto3` syntax, fields **should** always be marked optional.

But I think it's a bit orthogonal to the syntax directive, so maybe better specified somewhere else?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@toumorokoshi How about this?

@toumorokoshi
Copy link
Member

toumorokoshi commented Nov 12, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants