-
Notifications
You must be signed in to change notification settings - Fork 22
feat(191): allow and recommend use of editions #382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| ## Syntax | ||
|
|
||
| APIs defined in protocol buffers **must** use `proto3` syntax. | ||
| APIs defined in protocol buffers **must** use `proto3` syntax or one of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should also add all fields should be marked optional? Unless that's in a different AEP already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@toumorokoshi Do you mean when using proto3 syntax all fields should be marked optional? When using 2023 and above, it's all optional by default, so no optional directives needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can add another paragraph under the first one saying:
When using `proto3` syntax, fields **should** always be marked optional.But I think it's a bit orthogonal to the syntax directive, so maybe better specified somewhere else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@toumorokoshi How about this?
|
That sounds great! Yes, I was referring specifically to proto3.
2025年11月12日(水) 4:38 Oscar Söderlund ***@***.***>:
… ***@***.**** commented on this pull request.
------------------------------
In aep/general/0191/aep.md.j2
<#382 (comment)>:
> @@ -6,7 +6,10 @@ read.
## Syntax
-APIs defined in protocol buffers **must** use `proto3` syntax.
+APIs defined in protocol buffers **must** use `proto3` syntax or one of the
I can add another paragraph under the first one saying:
When using `proto3` syntax, fields **should** always be marked optional.
But I think it's a bit orthogonal to the syntax directive, so maybe better
specified somewhere else?
—
Reply to this email directly, view it on GitHub
<#382 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAC7QSH23UBPMXHV7BYACKL34MS4PAVCNFSM6AAAAACLUXF4D6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTINJTGIZTAMRXGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
🍱 Types of changes
What types of changes does your code introduce to AEP? Put an
xin the boxesthat apply
If/when accepted, I'll follow up with an update to https://github.com/aep-dev/api-linter/blob/main/rules/aep0191/proto_version.go