Skip to content

Conversation

juliannguyen4
Copy link
Collaborator

@juliannguyen4 juliannguyen4 commented Aug 27, 2025

  • For any API method that takes in a meta dictionary as a parameter, if meta.ttl is set to aerospike.TTL_CLIENT_DEFAULT, then if a command-level policy was passed to the API call, then the command-level policy's ttl should be used

Docs

https://aerospike-python-client--823.org.readthedocs.build/en/823/client.html#aerospike.Client.put

Extra changes:

  • client.put(): deprecate meta parameter in favor of setting ttl and gen options in the write policy
  • Fix client.remove_bins() not applying write policy's ttl if meta is not set or meta.ttl is set to aerospike.TTL_CLIENT_DEFAULT

TODO:

  • Would other API calls that take in a write policy apply the ttl setting?
  • docs need to be more clear?
  • Write tests that prove the command/config/meta ttl policies work as expected
  • If forcing command write policy to set ttl, config-level write policy options may be overwritten. put() is ok

@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2025

Codecov Report

❌ Patch coverage is 33.33333% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.19%. Comparing base (c38079a) to head (5c05df4).
⚠️ Report is 5 commits behind head on dev.

Files with missing lines Patch % Lines
src/main/conversions.c 41.66% 7 Missing ⚠️
src/main/policy.c 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #823       +/-   ##
===========================================
- Coverage   81.95%   50.19%   -31.77%     
===========================================
  Files          99       99               
  Lines       14082    14109       +27     
===========================================
- Hits        11541     7082     -4459     
- Misses       2541     7027     +4486     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants