Skip to content

making (more) arguments implicit: #602, #1648, #1672 revisited #2085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 13, 2023
Merged

making (more) arguments implicit: #602, #1648, #1672 revisited #2085

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ebe30e1
as per issue #2083
jamesmckinna Sep 10, 2023
24326c6
tidy up
jamesmckinna Sep 11, 2023
f14ab2e
`CHANGELOG`!
jamesmckinna Sep 13, 2023
3c4e762
Merge branch 'master' into pr1648+1672-bis
jamesmckinna Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -781,6 +781,9 @@ Non-backwards compatible changes
properties about the orderings themselves the second index must be provided
explicitly.

* The argument `xs` in `xs≮[]` in `Data.{List|Vec}.Relation.Binary.Lex.Strict`
introduced in PRs #1648 and #1672 has now been made implicit.

* Issue #2075 (Johannes Waldmann): wellfoundedness of the lexicographic ordering
on products, defined in `Data.Product.Relation.Binary.Lex.Strict`, no longer
requires the assumption of symmetry for the first equality relation `_≈₁_`,
Expand Down Expand Up @@ -2703,7 +2706,7 @@ Other minor changes

* Added new proofs in `Data.Vec.Relation.Binary.Lex.Strict`:
```agda
xs≮[] : ∀ {n} (xs : Vec A n) → ¬ xs < []
xs≮[] : {xs : Vec A n} → ¬ xs < []
<-respectsˡ : IsPartialEquivalence _≈_ → _≺_ Respectsˡ _≈_ →
∀ {m n} → _Respectsˡ_ (_<_ {m} {n}) _≋_
<-respectsʳ : IsPartialEquivalence _≈_ → _≺_ Respectsʳ _≈_ →
Expand Down
6 changes: 3 additions & 3 deletions src/Data/List/Relation/Binary/Lex/Strict.agda
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,11 @@ module _ {a ℓ₁ ℓ₂} {A : Set a} where
_≋_ = Pointwise _≈_
_<_ = Lex-< _≈_ _≺_

xs≮[] : ∀ xs → ¬ xs < []
xs≮[] _ (base ())
xs≮[] : ∀ {xs} → ¬ xs < []
xs≮[] (base ())

¬[]<[] : ¬ [] < []
¬[]<[] = xs≮[] []
¬[]<[] = xs≮[]

<-irreflexive : Irreflexive _≈_ _≺_ → Irreflexive _≋_ _<_
<-irreflexive irr (x≈y ∷ xs≋ys) (this x<y) = irr x≈y x<y
Expand Down
8 changes: 4 additions & 4 deletions src/Data/Vec/Relation/Binary/Lex/Strict.agda
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,11 +69,11 @@ module _ {_≈_ : Rel A ℓ₁} {_≺_ : Rel A ℓ₂} where
_≋_ = Pointwise _≈_
_<_ = Lex-< _≈_ _≺_

xs≮[] : ∀ {n} (xs : Vec A n) → ¬ xs < []
xs≮[] _ (base ())
xs≮[] : ∀ {n} {xs : Vec A n} → ¬ xs < []
xs≮[] (base ())

¬[]<[] : ¬ [] < []
¬[]<[] = xs≮[] []
¬[]<[] = xs≮[]

module _ (≺-irrefl : Irreflexive _≈_ _≺_) where

Expand Down Expand Up @@ -134,7 +134,7 @@ module _ {_≈_ : Rel A ℓ₁} {_≺_ : Rel A ℓ₂} where
where

<-wellFounded : ∀ {n} → WellFounded (_<_ {n})
<-wellFounded {0} [] = acc λ ys ys<[] → ⊥-elim (xs≮[] ys ys<[])
<-wellFounded {0} [] = acc λ ys ys<[] → ⊥-elim (xs≮[] ys<[])
<-wellFounded {suc n} xs = Subrelation.wellFounded <⇒uncons-Lex uncons-Lex-wellFounded xs
where
<⇒uncons-Lex : {xs ys : Vec A (suc n)} → xs < ys → (×-Lex _≈_ _≺_ _<_ on uncons) xs ys
Expand Down