A number of with are not really needed
#2363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmckinna
requested changes
Apr 15, 2024
jamesmckinna
changed the title
with are not really needed
jamesmckinna
approved these changes
Apr 18, 2024
|
Considered all, I'll enact about 2/3 of them. |
|
Looks good! |
gallais
reviewed
Apr 23, 2024
layout for readability Co-authored-by: G. Allais <[email protected]>
layout for readability Co-authored-by: G. Allais <[email protected]>
layout for readability Co-authored-by: G. Allais <[email protected]>
|
Thanks for the suggestions @gallais those did noticeably improve readability. |
gallais
approved these changes
Apr 23, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many many were actually closer to needed, so left alone.
Some
withwere made clearer (to be merely pattern matches, but ones that caused various things to reduce, sowithwas the better idiom to use).Basically the only ones that were not touched were the ones in
Data.List.Base!!