-
Notifications
You must be signed in to change notification settings - Fork 663
feat: add KV Event Publishing to vLLM v1 #1181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cff6e3a to
b2d0847
Compare
b2d0847 to
00a0687
Compare
00a0687 to
c9a4330
Compare
grahamking
reviewed
May 23, 2025
grahamking
reviewed
May 23, 2025
grahamking
reviewed
May 23, 2025
grahamking
reviewed
May 23, 2025
grahamking
reviewed
May 23, 2025
grahamking
reviewed
May 23, 2025
grahamking
reviewed
May 23, 2025
grahamking
reviewed
May 23, 2025
grahamking
reviewed
May 23, 2025
grahamking
reviewed
May 23, 2025
grahamking
reviewed
May 23, 2025
c9a4330 to
ee0dad7
Compare
ee0dad7 to
3c4e3cc
Compare
GuanLuo
reviewed
May 29, 2025
rmccorm4
reviewed
May 29, 2025
rmccorm4
reviewed
May 29, 2025
This was referenced May 29, 2025
1 task
|
@alec-flowers Hi, could you clarify if Dynamo uses the block_hash from VLLM? If it does, how does Dynamo ensure consistency between VLLM’s calculated block_hash (from BlockStore events) and its own block_hash caculated from request tokens? |
This was referenced Jun 5, 2025
This was referenced Jun 16, 2025
This was referenced Jul 22, 2025
This was referenced Jul 29, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
This PR enables KV Routing in vLLM v1 by introducing a new KVEventPublisherFromZmq that listens for KV events over ZeroMQ and forwards them to the Indexer.
Details:
Where should the reviewer start?
Start with dynamo/lib/llm/src/kv_router/publisher.rs to review the new ZMQ publisher implementation and its integration.
Builds off this PR: vllm-project/vllm#16750 to read the published events from Zmq and forward them along to the Indexer.
Notes
Builds on: vllm-project/vllm#16750
Known Issue To-Fix:
Follow-ups (future PR's):
Summary by CodeRabbit
New Features
Improvements
Bug Fixes
Documentation