-
Notifications
You must be signed in to change notification settings - Fork 663
test: Temporary exclude kvbm tests from vllm, nightly, gpu1... #2611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe pytest marker list in tests/kvbm/test_determinism.py was reduced to only kvbm, with e2e, slow, nightly, and gpu_1 markers commented out. A TODO was added to re-enable them when kvbm builds in CI. No test logic or control flow was modified. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
tests/kvbm/test_determinism.py (1)
32-32: Polish the TODO for consistency and traceability.Capitalize TODO/CI and state exactly what to re-enable. Optionally reference a tracking issue.
Apply:
-# Todo: enable the rest when kvbm is built in the ci +# TODO: Re-enable e2e/slow/nightly/gpu_1 markers when KVBM is built in CI. (track in ai-dynamo/dynamo#xxxx)
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
tests/kvbm/test_determinism.py(2 hunks)
🧰 Additional context used
🪛 GitHub Actions: Pre Merge Validation of (ai-dynamo/dynamo/refs/pull/2611/merge) by oandreeva-nv.
tests/kvbm/test_determinism.py
[error] 1-1: Black formatting failed. 1 file reformatted (tests/kvbm/test_determinism.py). Run 'black --write tests/kvbm/test_determinism.py' to fix.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Build and Test - dynamo
🔇 Additional comments (2)
tests/kvbm/test_determinism.py (2)
32-39: Apply Black formatting to tests/kvbm/test_determinism.pyThe CI gate is currently failing because this file needs to be reformatted with Black. Running
python3 -m black tests/kvbm/test_determinism.pyproduces the following diff:--- tests/kvbm/test_determinism.py 2025-08-21 19:13:06.789618+00:00 +++ tests/kvbm/test_determinism.py 2025-08-21 19:20:05.259435+00:00 @@ -1,6 +1,5 @@ - #!/usr/bin/env python3 # SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved. # SPDX-License-Identifier: Apache-2.0 @@ -30,14 +29,14 @@ # Test markers to align with repository conventions # Todo: enable the rest when kvbm is built in the ci pytestmark = [ pytest.mark.kvbm, -# pytest.mark.e2e, -# pytest.mark.slow, -# pytest.mark.nightly, -# pytest.mark.gpu_1, + # pytest.mark.e2e, + # pytest.mark.slow, + # pytest.mark.nightly, + # pytest.mark.gpu_1, ]Please apply and commit these changes to unblock CI:
python3 -m black tests/kvbm/test_determinism.py git add tests/kvbm/test_determinism.py git commit -m "chore: black-format tests/kvbm/test_determinism.py (CI gate)"
32-39: The script will reveal how the CI filters are configured and whether there’s an existing pytest config for marker deselection. Once we see the build-and-test job and any pytest.ini/pyproject.toml settings, we can confirm the appropriate skip-if guard usage.
Signed-off-by: Hannah Zhang <[email protected]>
Signed-off-by: Krishnan Prashanth <[email protected]>
Signed-off-by: nnshah1 <[email protected]>
Overview:
Details:
Where should the reviewer start?
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit
Tests
Chores