Bindings: fix missing wheel dependency in CUDA 13 container builds #966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi ovidiusm! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
|
/build |
ovidiusm
force-pushed
the
fix-wheel-dep
branch
from
71fee94 to
83cbf92
Compare
ovidiusm
force-pushed
the
fix-wheel-dep
branch
from
83cbf92 to
a3a07f0
Compare
Signed-off-by: Ovidiu Mara <[email protected]>
ovidiusm
force-pushed
the
fix-wheel-dep
branch
from
a3a07f0 to
e2d67c4
Compare
|
/build |
Signed-off-by: Ovidiu Mara <[email protected]>
|
/build |
ovidiusm
requested review from
a team,
aranadive,
brminich,
mkhazraee and
roiedanino
as code owners
brminich
approved these changes
Oct 30, 2025
mkhazraee
approved these changes
Oct 31, 2025
ovidiusm
added a commit
to ovidiusm/nixl
that referenced
this pull request
Oct 31, 2025
…i-dynamo#966) * Bindings: fix missing wheel dependency in CUDA 13 container builds Signed-off-by: Ovidiu Mara <[email protected]> * Fix nixlbench container installation Signed-off-by: Ovidiu Mara <[email protected]> --------- Signed-off-by: Ovidiu Mara <[email protected]>
nv-nmailhot
pushed a commit
that referenced
this pull request
Oct 31, 2025
) (#974) * Bindings: fix missing wheel dependency in CUDA 13 container builds * Fix nixlbench container installation --------- Signed-off-by: Ovidiu Mara <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In container builds,
nixlPython wheel must depend on the platform-specific build from the container:nixlandnixl-cu12;nixlandnixl-cu13;In wheel builds published on PyPi, we package
nixl,nixl-cu12andnixl-cu13;nixlmust depend onnixl-cu12.This PR:
nixl-cu12ornixl-cu13);nixl_cu12ornixl_cu13) is no longer a meson option;nixlalways depends on the platform-specific build from the containernixlfrom CUDA 12 manylinux image buildspip install .andpip install *whlwork in container buildsWhy?
On CUDA 13 container builds, nixl wheel could not be installed due to missing nixl-cu12 dependency.