add name to require.ensures

[aikar]

Hello,
While webpack 2 has import, this plugin still can be very valuable...

Can you please add it so that the imported module generates a name for the chunk as require.ensures 3rd argument?

The flaw with WP2 import is that you can't name the chunks. They are trying to resolve that, but who knows when that would be completed.

This plugin has opportunity to quickly provide a way to name the chunks.

[loganfsmyth]

Duplicate of #23

[ljharb]

I'm not sure what the benefit of a named chunk is.

Both this and #23 would be possible if there's a way the name could be generated deterministically for a given import(), but it'd be a spec violation for it to occur in the source code.

[aikar]

@loganfsmyth no it is not.

Let me clarify my request more.

I want

import("foo");

to translate to

require.ensures([], (require => {
    resolve(require("foo"))
}, "foo");

Relative path imports could calculate the path to remove ../

The benefit of named chunks is so the filenames and stats are more clear what the code contains.

It's hard to know what your 1.chunk.js contains without examining contents.

Where as seeing foo.chunk.js I can understand that code related to that code split is of that size.

[aikar]

simply resolving to relative paths to {dirname}_{filename} as its chunk name would be the simplest solution (and keeping import("module") as "module")

No changing of the spec for import() call itself, just changing the output to utilize the input module name.

This is the closest plugin to handle this type of rewrite. I'm really hoping you can do this as I don't have any experience with AST to do it myself at this time.

[ljharb]

@aikar i'd be happy to review a PR that does what you're talking about, especially if it require.resolves the path first

[aikar]

@ljharb I don't know how the AST stuff works :( nor do I have any time to learn about it currently.

[abhinavsingi]

@aikar - Webpack has released it - https://webpack.js.org/guides/code-splitting-async/#chunk-names