tracking React Native 0.24 compatibility/issues

[joenoon]

I'm opening this to track problems and gather information as I dig into this. If anyone has ideas or figures it out first, please update here. It looks like after upgrading to RN 0.24 there is an issue in DefaultRenderer not receiving the expected navigationState, and getting:

undefined is not an object (evaluating 'navigationState.index')

Logging the keys of navigationState inside DefaultRenderer, I see:

 [ 'layout',
  'navigationState',
  'onNavigate',
  'position',
  'scene',
  'scenes' ]

So it seems like its not getting the right value here for navigationState in 0.24. I did scan through the diff of NavigationExperimental on react-native between 0.22 and 0.24 but didn't see anything obvious.

I'll update here if I figure it out.

[joenoon]

I think I found a fix in the PR above

[sylvainbaronnet]

I upgraded RNRF to 3.22.22 and now the custom NavBar doesn't show up at all.

With RN 0.24.1

[sylvainbaronnet]

I tried previous versions of RNRF and the last version where the custom NavBar show up is the 3.22.8
With the 3.22.11 there's the bug. There's a change between these versions that introduce the bug.

(3.22.9 & 3.22.10 were not published to npm so I can't try them)

EDIT : with aksonov/react-native-router-flux#3.24 it works

[joenoon]

In case other people land here, as of today I'm using this combination successfully:

    "react-native": "0.24.1",
    "react-native-router-flux": "aksonov/react-native-router-flux#3.24"

[sylvainbaronnet]

There's still the problem with type="replace" but it's a RN bug

[jamesone]

@sylvainbaronnet Any update on a fix for this?

[aksonov]

@joenoon Could you check if it is possible to merge 3.24 with latest branch and upgrade it to usage with 0.26-rc? This way we will create new branch 3.26 and then will replace master when official 0.26 will be released.

[aksonov]

@sylvainbaronnet Maybe could you integrate 3.24 into master and then update imports?

[sylvainbaronnet]

Sorry I deleted my message because I realized imports were already updated in master.