God it would be nice if...

[duro]

...this was built with Redux. Just saying. Love the implementation, but with everyone jumping on the Redux band wagon, including myself, I'm not sure about mixing Flux implementations.

[aksonov]

I don't see anything wrong with mixing implementation, if you would use this component only for nav transitions. However i agree that mixing could be issue. It is possible to add abstraction layer and use different flux implementation, but it is not trivial, so PR is welcome.

[Mokto]

+1 (Great work BTW)

I forked react-native-counter-ios-android

I tried to pass props to route like this :

var RouterModule = React.createClass({
    render: function() {
        console.log('FROM ROUTER  : ',this.props.counter);
        return (
          <Router>
            <Schema name="default" sceneConfig={Animations.FlatFloatFromRight} />
            <Route {...this.props} name="launch" component={Counter} initial={true} hideNavBar={false} title="Launch"/>
          </Router>
        );
    }
});

When I increment the counter:

• console.log('FROM ROUTER : ',this.props.counter); is rightly updated
• but the subcomponent Counter) rerender with not updated counter value.

Please let me know if I am not clear.

[aksonov]

Please provide your code as github repo.

Pavel.

25 сент. 2015 г., в 19:55, Mokto notifications@github.com написал(а):

+1

I forked react-native-counter-ios-android

I tried to pass props to route like this :

var RouterModule = React.createClass({
render: function() {
console.log('FROM ROUTER : ',this.props.counter);
return (


<Route {...this.props} name="launch" component={Counter} initial={true} hideNavBar={false} title="Launch"/>

);
}
});
When I increment the counter:

console.log('FROM ROUTER : ',this.props.counter); is rightly updated
but the subcomponent Counter) rerender with not updated counter value.
Please let me know if I am not clear.

—
Reply to this email directly or view it on GitHub.

[Mokto]

Thanks for your quick answer.

My forked repo

The console.log in ./src/components/Counter.js and ./src/containers/Router.js show the issue.

Please let me know if you need anything else.

[aksonov]

Sorry, but it is not intended usage of this component. Router should be high-level app component, not internal one, so it doesn't change his props during app work. As I see Redux provides own router so looks like they are not compatible to each other.

[Mokto]

Ok, thank you anyway, I found a workaround. (connect every subcomponent with redux)