This repository was archived by the owner on Mar 7, 2019. It is now read-only.
Refactor entire code base to capture linter output using JSON #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Older versions of golangci-lint were sending output exclusively to /dev/stdout and using a more standard format. However, the latest version either has a bug or is changing from its original design, because there are errors and warnings in /dev/stderr too which differ from the other messages just by a few characters, for example, missing a colon after the column number. I’ve fixed these problems and improved the parser by leveraging the JSON output, and formalizing both /dev/stderr as Errors and /dev/stdout as warnings. I also went ahead and submitted the project to SublimeLinter repository for inclusion in their registry to allow people to install the linter via Package Control [1]. I immediately approached the original author to ask for a review and hopefully merge the fixes so others can benefit from the improvements. [1] SublimeLinter/package_control_channel#83
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older versions of
golangci-lintwere sending output exclusively to/dev/stdoutand using a more standard format. However, the latest version either has a bug or is changing from its original design, because there are errors and warnings in/dev/stderrtoo which differ from the other messages just by a few characters, for example, missing a colon after the column number. I’ve fixed these problems and improved the parser by leveraging the JSON output, and formalizing both/dev/stderras Errors and/dev/stdoutas warnings.I also went ahead and submitted the project to SublimeLinter repository for inclusion in their registry to allow people to install the linter via Package Control [1]. I immediately approached the original author to ask for a review and hopefully merge the fixes so others can benefit from the improvements.
[1] SublimeLinter/package_control_channel#83