MAGE-1459 Total records resolver #5
Merged
+1,146
−303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damcou
previously approved these changes
Nov 5, 2025
Collaborator
damcou
left a comment
damcou
left a comment
There was a problem hiding this comment.
Nice job ! 🙌
Tests are passing and I think I get most of the code, had a few comments but nothing blocking, this can be tackled later in your next ticket.
This still hard to guess what belongs to our codebase and what is still from the core modules with all the mocked stuff but we are on a good path I believe :)
Collaborator
Author
|
Yeah the mock stuff is just a frame of reference to help me understand what I actually need to build. I will rip all that out at the end. |
Collaborator
Author
|
@damcou Thanks for the review! I've made some updates based on your feedback if you wouldn't mind please having another look. |
damcou
approved these changes
Nov 6, 2025
Collaborator
damcou
left a comment
damcou
left a comment
There was a problem hiding this comment.
LGTM 🚀 🙌
Thanks for making the changes !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims to provide a more robust pagination mechanism for backend search:
algoliaengineTotalRecordsResolverQueryMapperandDocumentMapperNOTE: This depends on changes from core module under algolia/algoliasearch-magento-2#1860
Result
