adding get method tests #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algochoi
reviewed
Jun 7, 2022
Contributor
algochoi
left a comment
algochoi
left a comment
There was a problem hiding this comment.
Looking good - just wondering what would happen if the method name is not unique and if there is a test case for that.
Co-authored-by: algochoi <[email protected]>
…-testing into get-method-by-name
barnjamin
force-pushed
the
get-method-by-name
branch
from
f7b3cdd to
e2036cb
Compare
barnjamin
force-pushed
the
get-method-by-name
branch
from
60e319d to
126f53f
Compare
tzaffi
reviewed
Jun 9, 2022
tzaffi
reviewed
Jun 9, 2022
tzaffi
reviewed
Jun 9, 2022
Co-authored-by: Zeph Grunschlag <[email protected]>
Co-authored-by: Zeph Grunschlag <[email protected]>
tzaffi
reviewed
Jun 9, 2022
tzaffi
approved these changes
Jun 9, 2022
Contributor
|
Another request also before merging - can you add a PR description? |
jasonpaulos
approved these changes
Jun 9, 2022
Contributor
jasonpaulos
left a comment
jasonpaulos
left a comment
There was a problem hiding this comment.
Looks good, thanks for making tests
tzaffi
reviewed
Jun 9, 2022
Co-authored-by: Zeph Grunschlag <[email protected]>
…-testing into get-method-by-name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding tests for the
get_method-by-namemethods in the SDKs for Interface and Contract objects. They should return the method with the name if there is only 1 and error if none or >1 are found