API: Disable rewinding and reject the query param on account lookups and … #1630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cce
approved these changes
Sep 12, 2024
algorandskiy
approved these changes
Sep 13, 2024
agodnic
added a commit
to AlgoNode/indexer
that referenced
this pull request
Dec 12, 2024
…ps and searches. (algorand#1630)" This reverts commit 249016c.
gmalouf
added a commit
to gmalouf/indexer
that referenced
this pull request
Jan 13, 2025
…ps and searches. (algorand#1630)" This reverts commit 249016c. The synthetic transaction implementation of payouts in the indexer should allow balances retrieved via rewind to calculate as before.
gmalouf
added a commit
that referenced
this pull request
Jan 13, 2025
* Revert "Disable rewinding and reject the query param on account lookups and searches. (#1630)" This reverts commit 249016c. The synthetic transaction implementation of payouts in the indexer should allow balances retrieved via rewind to calculate as before. * GCI lint warning fix. * Add HeartbeatTxn to be ignored during rewinding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Disable rewinding and reject the query param on account lookups and searches.
This is intended to close #1625 - rewinding carries it with several nuances for limited overall benefit and minimal actual usage.
Test Plan
API tests were added to ensure a bad request is returned if the
round=parameter is in the requests to the account lookup/search endpoints.