Skip to content

Conversation

@barnjamin
Copy link
Contributor

No description provided.

@barnjamin barnjamin requested review from ahangsu and winder March 22, 2022 12:07
@ahangsu
Copy link
Contributor

ahangsu commented Mar 22, 2022

When I use the generator to run against java sdk, it seems also remove the HashType code in model, do you know what is happening?

@barnjamin
Copy link
Contributor Author

@ahangsu no idea, weird right?

@ahangsu
Copy link
Contributor

ahangsu commented Mar 22, 2022

I believe this problem was also described in algorand/generator#19, not sure how it made its way in generator...

@ahangsu
Copy link
Contributor

ahangsu commented Mar 22, 2022

OK, I remembered it: HashType enum type in Java-SDK will be manually added until stateproof is added to indexer oas2 json.
So I assume it should be just fine to add it back manually...?

Copy link
Contributor

@ahangsu ahangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems correct to me with code changes only in removing JsonProperty decorator from generator code change, waiting on @winder to call the shot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants