Skip to content

Deprecation: Add deprecation tags to v1 algod API #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 15, 2022
Merged

Deprecation: Add deprecation tags to v1 algod API #388

merged 3 commits into from
Sep 15, 2022

Conversation

@algochoi
Copy link
Contributor

@algochoi algochoi commented Sep 12, 2022 •
edited
Loading

This PR adds deprecation tags to the Javadocs to v1 algod APIs and related models/utilities.

Related issue here: algorand/algorand-sdk-testing#218

@michaeldiamant michaeldiamant mentioned this pull request Sep 13, 2022
Closed
@algochoi algochoi marked this pull request as ready for review September 13, 2022 13:06
michaeldiamant
michaeldiamant approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@michaeldiamant michaeldiamant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@algochoi Matches my expectations of what we agreed to deprecate. Prefer a 2nd reviewer approves prior to merge.

ahangsu
ahangsu reviewed Sep 13, 2022
View reviewed changes
@winder
Copy link
Contributor

winder commented Sep 14, 2022 •
edited
Loading

How are you determining the overlap between Kmd and Algod v1 functionality? The most convenient reference I have for KMD is the README example, it imports the following:

import com.algorand.algosdk.kmd.client.ApiException;
import com.algorand.algosdk.kmd.client.KmdClient;
import com.algorand.algosdk.kmd.client.api.KmdApi;
import com.algorand.algosdk.kmd.client.model.*;

edit: Nevermind! I didn't realize the v1 API had 2 copies of everything.

@winder winder merged commit e4efd98 into develop Sep 15, 2022
@winder winder deleted the deprecate-v1-api branch September 15, 2022 13:04
@algolucky algolucky mentioned this pull request Sep 19, 2022
Merged
algolucky pushed a commit that referenced this pull request Sep 20, 2022
@algochoi @algolucky
Deprecation: Add deprecation tags to v1 algod API (#388)
63b996d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@winder winder winder approved these changes

@michaeldiamant michaeldiamant michaeldiamant approved these changes

@ahangsu ahangsu ahangsu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@algochoi @winder @michaeldiamant @ahangsu