Bug-Fix: parsing type strings for tuples containing static arrays of tuples #431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahangsu
changed the title
algochoi
approved these changes
Nov 28, 2022
Contributor
algochoi
left a comment
algochoi
left a comment
There was a problem hiding this comment.
Thanks for the fix + tests look good!
michaeldiamant
approved these changes
Nov 29, 2022
Contributor
michaeldiamant
left a comment
michaeldiamant
left a comment
There was a problem hiding this comment.
@ahangsu Thanks for supplying a fix - As intended, I confirmed:
- Added tests fail prior to the PR.
- Implementation mirrors other SDKs.
Out-of-scope passing remark: I can imagine building a property-based test as a way to build more confidence in test case generation. Though it's a big enough effort that I don't think it's worth pursuing in-scope to the story.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix algorand/avm-abi#12