Patch: Remove de-duping via HashSet from accounts,foriegn apps, and foreign … #652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…assets setters in MethodCallTransactionBuilder. Now set solely via lists to ensure stable ordering maintained.
gmalouf
changed the title
jasonpaulos
approved these changes
Oct 25, 2023
gmalouf
added a commit
that referenced
this pull request
Oct 25, 2023
* Remove de-duping via HashSet from accounts,foriegn apps, and foreign assets setters in MethodCallTransactionBuilder. Now set solely via lists to ensure stable ordering maintained. (#652) * bump up version to 2.4.0 --------- Co-authored-by: John Lee <[email protected]> Co-authored-by: Gary <[email protected]> Co-authored-by: gmalouf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…assets setters in MethodCallTransactionBuilder. Now set solely via lists to ensure stable ordering maintained.
Addresses #651
Existing unit and integration tests were run / are passing.