Skip to content

Conversation

@cce
Copy link
Contributor

@cce cce commented Sep 5, 2025

@cce cce added the Enhancement label Sep 5, 2025
@cce cce requested a review from Copilot September 5, 2025 19:32
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for "lmsig" (logicsig multisig signatures) to the Algorand SDK, expanding the existing signature types beyond just regular signatures ("sig") and legacy multisig signatures ("msig"). The implementation allows logic signatures to be signed by multisig addresses with proper verification and encoding support.

Key changes include:

  • Added new lmsig field and signature counting logic to LogicsigSignature
  • Updated account classes to handle the new signature type
  • Modified signature verification to use multisig-specific signing data

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/main/java/com/algorand/algosdk/crypto/LogicsigSignature.java Adds lmsig field, sigCount method, and multisig-specific verification logic
src/main/java/com/algorand/algosdk/account/LogicSigAccount.java Updates constructors and address resolution to support lmsig signatures
src/main/java/com/algorand/algosdk/account/Account.java Modifies logicsig signing methods to use lmsig instead of legacy msig
src/test/java/com/algorand/algosdk/account/TestLogicSigAccount.java Updates tests to verify lmsig functionality and expected serialization
src/test/java/com/algorand/algosdk/crypto/TestLogicsigSignature.java Adds assertion for lmsig field in multisig test
src/test/resources/msig_delegated.txn Test vector for lmsig delegated transaction
src/test/resources/msig_delegated_other.txn Test vector for lmsig delegated transaction with different sender

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@cce cce merged commit 736ad61 into algorand:main Sep 8, 2025
4 checks passed
@cce cce deleted the lmsig branch September 8, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants