adding getMethodByName function to Contract and Interface #583
Conversation
barnjamin
force-pushed
the
get-method-by-name
branch
from
028a4ae to
824c750
Compare
algochoi
left a comment
algochoi
left a comment
There was a problem hiding this comment.
Minor comment while we wait for firefox tests
barnjamin
force-pushed
the
get-method-by-name
branch
from
e8c285f to
a80f3a3
Compare
| .setPreference('remote.active-protocols', 1) // Sets protocol to only WebDriver BiDi | ||
| .setPreference('network.http.network-changed.timeout', 30) // In Docker tests this apparently matters |
There was a problem hiding this comment.
Interesting, I'd expect setting remote.active-protocols to 2 (CDP) to be the solution here, since in Firefox 101 they changed the default from 2 to 3 (1|2).
Also, for network.http.network-changed.timeout, have you tried more values, or just 30?
There was a problem hiding this comment.
to be fair 1 was the first one I tried, something about the combination is tripping us.
I did not try more settings for timeout, 30s seemed sufficient, the default is 5
jasonpaulos
left a comment
jasonpaulos
left a comment
There was a problem hiding this comment.
Looks good! Thanks again for all the debugging work related to Firefox.
Once @algochoi agrees, this looks good to merge, and I hope this will be the last of the flaky Firefox tests 🙏
No description provided.