Skip to content

Conversation

gregoire-dl
Copy link
Member

Description

This PR modifies the structure of the JSON file used for sphere detection.
The new format is compatible with the structure expected by Meshroom, allowing spheres to be displayed directly in the interface.

Features list

  • Write JSON shape file in sphereDetection.
  • Read JSON shape file in lightCalibration.
  • Add shape file semantic for JSON file in SphereDetection software.

@gregoire-dl gregoire-dl added this to the 3.4.0 milestone Oct 7, 2025
@gregoire-dl gregoire-dl self-assigned this Oct 7, 2025
Copy link
Contributor

@cbentejac cbentejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected! ⭐⭐⭐⭐⭐

I am not merging it straight away because it makes the "Display Lighting Circle : Sphere Detection" from the 2D Viewer useless, and since the display of the shape is now handled from the Node Editor, it should probably be removed altogether.

Copy link
Contributor

@cbentejac cbentejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually there's a missing part in this PR: if the "Automatic Sphere Detection" option is disabled, the position of the sphere is supposed to be provided by the user. So we need to add a Circle attribute to replace the "Sphere Center" / "Sphere Radius" attributes, and use the position of the circle in sphereDetection.cpp to write the ouput detection.json accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants