feat: Implement FromTxWithEncoded and FromRecoveredTx from OpTxEnvelope for TxEnv
#94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nvelope` for `TxEnv`
RomanHodulak
force-pushed
the
op-tx-env-impl
branch
from
abb8748 to
4c566f3
Compare
nadtech-hub
pushed a commit
to nadtech-hub/evm
that referenced
this pull request
Jun 3, 2025
…nvelope` for `TxEnv` (alloy-rs#94)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
While working on the
custom_nodeexample I intended to implementFromTxWithEncoded<CustomTransaction> for CustomTxEnvand the same withFromRecoveredTx. The approach I took was to redirect toFromTxWithEncoded<Inner> for TxEnv. This is, however, not implemented forTxEnv, but only forOpTransaction<TxEnv>Solution
Extract
impl FromTxWithEncoded<OpTxEnvelope> for TxEnvandFromRecoveredTxcounterpart fromimpl FromTxWithEncoded<OpTxEnvelope> for OpTransaction<TxEnv>PR Checklist