-
-
Notifications
You must be signed in to change notification settings - Fork 41
fix(influx): update influxdb cog to use correct table for starboard s… #846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis pull request updates the InfluxDB logger to query the Sequence Diagram: Updated Starboard Statistics Query in InfluxDBLoggersequenceDiagram
participant Logger as "InfluxDBLogger.logger()"
participant DB as "Database"
Logger->>DB: find_many on "starboard_message" table (with guild_id)
note over Logger,DB: Previously queried "starboard" table
DB-->>Logger: Returns starboard_stats
Class Diagram: Modification in InfluxDBLogger for Starboard StatsclassDiagram
class InfluxDBLogger {
+logger() None
}
note for InfluxDBLogger "The logger() method was updated to fetch starboard statistics from the 'starboard_message' table instead of the 'starboard' table."
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @thanosengine - I've reviewed your changes - here's some feedback:
- Please consider completing the PR description template, particularly the guidelines checklist and the section on how this change was tested.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
…tats
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change. If this change fixes any issues please put "Fixes #XX" in the description. Please also ensure to add the appropriate labels to the PR.
Guidelines
My code follows the style guidelines of this project (formatted with Ruff)
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation if needed
My changes generate no new warnings
I have tested this change
Any dependent changes have been merged and published in downstream modules
I have added all appropriate labels to this PR
I have followed all of these guidelines.
How Has This Been Tested? (if applicable)
Please describe how you tested your code. e.g describe what commands you ran, what arguments, and any config stuff (if applicable)
Screenshots (if applicable)
Please add screenshots to help explain your changes.
Additional Information
Please add any other information that is important to this PR.
Summary by Sourcery
Bug Fixes: