Skip to content

fix(influx): update influxdb cog to use correct table for starboard s… #846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025

Conversation

anemoijereja-eden
Copy link
Collaborator

@anemoijereja-eden anemoijereja-eden commented May 6, 2025

…tats

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change. If this change fixes any issues please put "Fixes #XX" in the description. Please also ensure to add the appropriate labels to the PR.

Guidelines

  • My code follows the style guidelines of this project (formatted with Ruff)

  • I have performed a self-review of my own code

  • I have commented my code, particularly in hard-to-understand areas

  • I have made corresponding changes to the documentation if needed

  • My changes generate no new warnings

  • I have tested this change

  • Any dependent changes have been merged and published in downstream modules

  • I have added all appropriate labels to this PR

  • I have followed all of these guidelines.

How Has This Been Tested? (if applicable)

Please describe how you tested your code. e.g describe what commands you ran, what arguments, and any config stuff (if applicable)

Screenshots (if applicable)

Please add screenshots to help explain your changes.

Additional Information

Please add any other information that is important to this PR.

Summary by Sourcery

Bug Fixes:

  • Fixed database query to use 'starboard_message' table instead of 'starboard' table when collecting starboard statistics

Copy link

trunk-io bot commented May 6, 2025

⏱️ 5m total CI duration on this PR

Job Cumulative Duration Recent Runs
docker 2m 🟩
Analyze (python) 1m 🟩
Analyze (actions) 1m 🟩
pyright 41s 🟩
Ruff 29s 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor

sourcery-ai bot commented May 6, 2025

Reviewer's Guide

This pull request updates the InfluxDB logger to query the starboard_message table instead of the starboard table when fetching starboard statistics. This is achieved by changing the table name in the database query within the logger method.

Sequence Diagram: Updated Starboard Statistics Query in InfluxDBLogger

sequenceDiagram
    participant Logger as "InfluxDBLogger.logger()"
    participant DB as "Database"

    Logger->>DB: find_many on "starboard_message" table (with guild_id)
    note over Logger,DB: Previously queried "starboard" table
    DB-->>Logger: Returns starboard_stats
Loading

Class Diagram: Modification in InfluxDBLogger for Starboard Stats

classDiagram
    class InfluxDBLogger {
        +logger() None
    }
    note for InfluxDBLogger "The logger() method was updated to fetch starboard statistics from the 'starboard_message' table instead of the 'starboard' table."
Loading

File-Level Changes

Change Details Files
Corrected the database table queried for starboard statistics in the InfluxDB logger.
  • Modified the database query to use self.db.starboard_message instead of self.db.starboard for fetching starboard data per guild.
tux/cogs/services/influxdblogger.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@electron271 electron271 merged commit ffee016 into main May 6, 2025
8 of 9 checks passed
@electron271 electron271 deleted the fix_influx branch May 6, 2025 18:09
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @thanosengine - I've reviewed your changes - here's some feedback:

  • Please consider completing the PR description template, particularly the guidelines checklist and the section on how this change was tested.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

sentry-io bot commented May 11, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ 2025-05-11 18:25:41.965 | ERROR | tux.database.controllers.base:_execute_query:108 - Failed to find records in starboardmessage with criteria {'guild_id': 1172245377395728464}: Could not find field at findManyStarboardMessage.where.guild_id tux.cog_loader.CogLoader.load_cogs_from_folder View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants