-
-
Notifications
You must be signed in to change notification settings - Fork 40
refactor: Continue dynamic moderation refactoring timeout arguments #977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
kzndotsh
wants to merge
60
commits into
refactor/moderation
Choose a base branch
from
cursor/continue-dynamic-moderation-refactoring-timeout-arguments-5dbb
base: refactor/moderation
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
refactor: Continue dynamic moderation refactoring timeout arguments #977
kzndotsh
wants to merge
60
commits into
refactor/moderation
from
cursor/continue-dynamic-moderation-refactoring-timeout-arguments-5dbb
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Deploying tux with
|
Latest commit: |
94f3bfc
|
Status: | ✅ Deploy successful! |
Preview URL: | https://303eb3f0.tux-afh.pages.dev |
Branch Preview URL: | https://cursor-continue-dynamic-mode.tux-afh.pages.dev |
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
…mentations Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Co-authored-by: admin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR advances the refactoring for a dynamic moderation system by completing the command-level configuration for various moderation commands.
Summary of Changes:
supports_reason=True
andsupports_silent=True
flags to theModerationCommandConfig
entries forwarn
,jail
,unjail
,unban
,untimeout
,snippetban
,snippetunban
,pollban
, andpollunban
commands intux/cogs/moderation/command_config.py
.python.languageServer
toNone
in.vscode/settings.json
.Motivation and Context:
This change is a critical step in building a truly dynamic and DRY (Don't Repeat Yourself) moderation command system. By formalizing these flags within the
ModerationCommandConfig
dataclass, we ensure that all moderation commands have a consistent and explicit definition of their capabilities regarding reasons and silent execution. This completed configuration is foundational for the next phases, which involve automatically generating commands and unifying argument parsing, ultimately leading to significant code reduction, consistent user experience, and easier maintenance.Guidelines
My code follows the style guidelines of this project (formatted with Ruff)
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation if needed
My changes generate no new warnings
I have tested this change
Any dependent changes have been merged and published in downstream modules
I have added all appropriate labels to this PR
I have followed all of these guidelines.
How Has This Been Tested? (if applicable)
The existing test suite was executed, and all tests passed successfully.
Screenshots (if applicable)
N/A
Additional Information
This PR solidifies the command configuration layer, which is essential for the subsequent implementation of a unified command runner and automatic command registration, as outlined in the overall refactoring plan.
Open in Web • Open in Cursor • Open Docs