Skip to content

Conversation

ianlcsd
Copy link

@ianlcsd ianlcsd commented Dec 17, 2015

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code style: indent lines 511-512 only two spaces over line 510.

@ianlcsd
Copy link
Author

ianlcsd commented Dec 18, 2015

Jenkins, test this please.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't re-order the imports.

@ianlcsd ianlcsd force-pushed the csd-1.5 branch 2 times, most recently from fcd6955 to ef82527 Compare December 18, 2015 17:38

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: preference in the codebase for assertResult that extends over more than one line appears to be:

assertResult(foo) {
  .
  .
  .
}

@ianlcsd ianlcsd changed the title SPY-885: CSD's FileSelector is not applied in case of Parquet/SparkSQL SPY-885: CSD's FileSelector is not applied for Parquet in SparkSQL query Dec 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...selected directories are empty.

markhamstra added a commit that referenced this pull request Dec 18, 2015
SPY-885: CSD's FileSelector is not applied for Parquet in SparkSQL query
@markhamstra markhamstra merged commit d0854e3 into alteryx:csd-1.5 Dec 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants