fix(session-replay-browser): disable capture when remote config unavailable #1390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| sessionReplayRemoteConfig.sr_targeting_config = targetingConfig; | ||
| } | ||
| } | ||
| } else { |
There was a problem hiding this comment.
Bug: Config Glitch Disables Session Replay
The condition for populating sessionReplayRemoteConfig only checks samplingConfig, privacyConfig, and targetingConfig, but ignores sr_interaction_config and sr_logging_config which are also valid session replay configurations. When remote config contains only sr_interaction_config or sr_logging_config, sessionReplayRemoteConfig remains undefined, triggering the kill switch to disable capture even though valid remote config was received. This incorrectly disables capture when interaction or logging configs are present.
|
📝 Documentation updates detected! New suggestion: Clarify Session Replay remote config kill switch behavior |
…ilable Force disable session replay capture when remote configuration is not available, regardless of whether the fetch failed or returned no session replay configuration. This ensures the remote config acts as a proper kill switch mechanism. Previously, capture could remain enabled if remote config fetch succeeded but returned no session replay configuration, defeating the kill switch purpose. Changes: - Always set captureEnabled=false when sessionReplayRemoteConfig is undefined - Add distinct warning messages for fetch failure vs missing configuration - Update tests to verify both failure scenarios - Add test case for successful fetch with no SR configuration Fixes SR-2083
lewgordon-amplitude
force-pushed
the
SR-2083
branch
from
05e91e8 to
c2d3e32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Force disable session replay capture when remote configuration is not available, regardless of whether the fetch failed or returned no session replay configuration. This ensures the remote config acts as a proper kill switch mechanism.
Previously, capture could remain enabled if remote config fetch succeeded but returned no session replay configuration, defeating the kill switch purpose.
Checklist
Note
Force-disable Session Replay capture when remote config is unresolved or lacks session replay config; update tests to reflect new kill-switch behavior.
packages/session-replay-browser/src/config/joined-config.ts):remoteConfigFailedtracking and disableconfig.captureEnabledwhen remote config is null or lackssessionReplayconfig.sr_*configs are present.test/config/joined-config.test.ts) to expectcaptureEnabled: falsewhen remote config is null or missingsessionReplayand adjust cases for ignoring improper keys.test/integration/sampling.test.ts) to ensure no capture or sampling checks when remote config cannot be resolved, and validate sampling behavior when remote config only setscapture_enabled.Written by Cursor Bugbot for commit 05e91e8. Configure here.