Skip to content

Specify the units for Mutual Information scores #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 478 commits into
base: master
Choose a base branch
from
Open

Specify the units for Mutual Information scores #1

wants to merge 478 commits into from

Conversation

amrcode
Copy link
Owner

@amrcode amrcode commented Sep 23, 2020 •
edited
Loading

This PR adds documentation to the return values of the mutual-information-score functions to make it clear that the units are based on the natural logarithm. It also indicates how the parameters are related to the mathematical representations.

@amrcode amrcode force-pushed the specify-units-for-mutual-information-metrics branch from 3e32ad7 to f8a079d Compare October 19, 2020 14:46
AlekLefebvre and others added 29 commits March 10, 2021 11:27
@AlekLefebvre @ogrisel
Fix Calibrated classifier cv predictions with pipeline (scikit-learn#…
ad7c316 
…19641)


Co-authored-by: Alek Lefebvre <[email protected]>
Co-authored-by: Olivier Grisel <[email protected]>
@geofft
MNT Make setup.py command parsing more robust (scikit-learn#19650)
4beb0c2 
Separate arguments into options and commands, and use setuptools.setup
if all the requested commands can / should run without NumPy installed,
even if there are options present.

This fixes a bug where `setup.py --no-user-site egg_info` wants NumPy to
be installed, even though `setup.py egg_info` works fine.
@ogrisel
DOC Use term 'black people' instead of 'blacks' in Boston descr (scik…
58af019 
…it-learn#19661)
@Erotemic @glemaitre
ENH Speedup confusion_matrix (scikit-learn#9843)
5980455 
Co-authored-by: Guillaume Lemaitre <[email protected]>
@thomasjpfan
BUG Fixes verbose > 2 for grid search (scikit-learn#19659)
6f180d7
@thomasjpfan
TST Do not use cache in test_fetch_openml_iris (scikit-learn#19594)
bfd7b58
@shivamgargsya
TST Change assert from sklearn to pytest style in module linear_model…
5ccfabf 
…/tests (scikit-learn#19565)
@jeremiedbb
move kmpp public next to kmpp private (scikit-learn#19666)
579e7de
@cmarmo
RFC Make non_negative_factorization call NMF instead of the opposite (s…
15fd026 
…cikit-learn#19607)
@PierreAttard @ogrisel
ENH Raises error in hinge_loss when 'pred_decision' is invalid (sciki…
f4e692c 
…t-learn#19643)

Co-authored-by: Olivier Grisel <[email protected]>
@MarcoGorelli
MNT Remove absolute imports (scikit-learn#19668)
e3e4a77
@jjerphan
ENH Optimize dot product order for LogisticRegression for dense matri…
0c74b8b 
…ces (scikit-learn#19571)

* Use multi_dot for Hessian and gradient product. 
  np.linalg.multi_dot quickly chooses the best order for the multiplication of three matrices.
@alessiamarcolini
DOC Fix typo in plot_multi_metric_evaluation example (scikit-learn#19675
95c3c76 
)
@cliffordEmmanuel @thomasjpfan @cinbez
ENH Deprecated the default random_state=0 in randomized_svd (scikit-l…
77e998d 
…earn#19670)

Co-authored-by: Thomas J. Fan <[email protected]>
Co-authored-by: cinbez <[email protected]>
@zouharvi @thomasjpfan
MNT Fix error message for Minkowski metric parameter (scikit-learn#19671
ac6dea5 
)

Co-authored-by: Thomas J. Fan <[email protected]>
@LSturtew
FIX RuntimeWarning by dividing by zero in test_iforest_with_uniform_d…
302106b 
…ata (scikit-learn#19622)
@thomasjpfan @ogrisel @lorentzenchr
ENH Adds _num_features for array-likes (scikit-learn#19633)
d996eaf 
Co-authored-by: Olivier Grisel <[email protected]>
Co-authored-by: Christian Lorentzen <[email protected]>
@azihna
TST Change assert from sklearn to pytest style in tests/test_pipeline…
edc4f15 
….py (scikit-learn#19678)
@mbatoul
FIX RuntimeWarning division by zero in check_classifiers_one_label (s…
b7b510f 
…cikit-learn#19690)
@ogrisel
TST Add a test to check the consistency of the Ridge and ElasticNet(l…
fcf4740 
…1_ratio=0) solutions (scikit-learn#19620)
@stestagg
[MRG] Fix documentation for russelrao formula (scikit-learn#19695)
36e4358
@mlondschien @ogrisel @lorentzenchr
ENH Add periodic extrapolation to SplineTransformer (scikit-learn#19483)
95b7c68 
Co-authored-by: Olivier Grisel <[email protected]>
Co-authored-by: Christian Lorentzen <[email protected]>
@alfaro96
CI Use conda instead of pip to install anaconda-client (scikit-learn#…
edc6995 
…19528)
@ogrisel
MAINT Python 3.9 in badge on README.rst (scikit-learn#19702)
9a186a5
@seanbenhur
DOC Added utils.gen_batches in documentation (scikit-learn#19688)
04f84c6
@thomasjpfan
ENH Better error for corrupted files in fetch_kddcup99 (scikit-learn#…
2e7009b 
…19669)
@avigupta2612 @rth
MNT move PolynomialFeatures from _data.py to _polynomial.py (scikit-l…
ca9618c 
…earn#19611)

Co-authored-by: Roman Yurchak <[email protected]>
@mblondel
Fix typo in elastic net docstring. (scikit-learn#19711)
0d7d46f 
* Fix typo in elastic net docstring.

* Use norms more explicitly.
@joclement
DOC Correct scorer documentation (scikit-learn#19720)
bf4049c 
Co-authored-by: Joris Clement <[email protected]>
thomasjpfan and others added 29 commits June 3, 2021 14:28
@thomasjpfan
FIX Uses points instead of pixels in plot_tree (scikit-learn#20023)
3a23e26
@jeremiedbb
MNT n_features_in through the multiclass module (scikit-learn#20193)
6bfaced
@thomasjpfan
CI Removes python 3.6 builds from wheel building (scikit-learn#20184)
1038024
@mlondschien
FIX Fix typo in error message in fetch_openml (scikit-learn#20201)
95f5fb4
FIX Fix error when using Calibrated with Voting (scikit-learn#20087)
7b965c7
@murata-yu @ogrisel @thomasjpfan
FIX Fix RandomForestRegressor doesn't accept max_samples=1.0 (scikit-…
a1a6b3a 
…learn#20159)

Co-authored-by: Olivier Grisel <[email protected]>
Co-authored-by: Thomas J. Fan <[email protected]>
@bsun94 @lorentzenchr
@azihna @cmarmo @ogrisel @naozin555 @venkyyuvy @thomasjpfan
ENH Adds Poisson criterion in RandomForestRegressor (scikit-learn#19836)
36915ae 
Co-authored-by: Christian Lorentzen <[email protected]>
Co-authored-by: Alihan Zihna <[email protected]>
Co-authored-by: Alihan Zihna <[email protected]>
Co-authored-by: Chiara Marmo <[email protected]>
Co-authored-by: Olivier Grisel <[email protected]>
Co-authored-by: naozin555 <[email protected]>
Co-authored-by: Venkatachalam N <[email protected]>
Co-authored-by: Thomas J. Fan <[email protected]>
TST Replace assert_warns from decomposition/tests (scikit-learn#20214)
9884ccd
@glemaitre @ogrisel @jeremiedbb
TST check n_features_in_ in pipeline module (scikit-learn#20192)
800aee6 
Co-authored-by: Olivier Grisel <[email protected]>
Co-authored-by: Jérémie du Boisberranger <[email protected]>
Co-authored-by: Olivier Grisel <[email protected]>
@mlondschien @ogrisel
Allow n_knots=None if knots are explicitly specified in `SplineTran…
7781256 
…sformer` (scikit-learn#20191)


Co-authored-by: Olivier Grisel <[email protected]>
@ogrisel
FIX make check_complex_data deterministic (scikit-learn#20221)
673625b
@jeremiedbb
TST test_fit_docstring_attributes include properties (scikit-learn#20190
b15e312 
)
@thomasjpfan
FIX Uses the color max for colormap in ConfusionMatrixDisplay (scikit…
7f30867 
…-learn#19784)
@itsabhishekhere
STY Changing .format method to f-string formatting (scikit-learn#20215)
5c3cb6b
@hongshaoyang @jjerphan
@thomasjpfan @cmarmo
[MRG] Listed valid metrics in neighbors.rst (scikit-learn#19379)
c53d33e 
Co-authored-by: Julien Jerphanion <[email protected]>
Co-authored-by: Thomas J. Fan <[email protected]>
Co-authored-by: Chiara Marmo <[email protected]>
@nanshanli
DOC Document n_features_in_ in cluster (scikit-learn#20228)
45fc4b7
@glemaitre
TST make sure to test SearchCV on both classification and regression (s…
a253826 
…cikit-learn#20202)
@thomasjpfan
FIX Do not reset for non-fit in multiclass (scikit-learn#20205)
007da8d
@glemaitre
DOC add n_features_in_ in the documentation (scikit-learn#20236)
1cd282d
@amrcode
Update _supervised.py
bf380eb
@amrcode
Update _supervised.py
7421170 
Fix lint issues in doc updates.
@amrcode @cmarmo
Update sklearn/metrics/cluster/_supervised.py to add a period in the …
7cb0dbe 
…return value doc

Co-authored-by: Chiara Marmo <[email protected]>
@amrcode
Updates from review
14df87f
@amrcode
Fix line lengths
6c1c787
@amrcode
Update _supervised.py
b6e1275 
Line length adjustment
@amrcode
Remove trailing whitespace
85aa9ec
@amrcode
Update math notation
e8ff404
@amrcode
Fix line lengths
bdc8ba9
@amrcode
Remove trailing whitespace
26e2064
@amrcode amrcode force-pushed the specify-units-for-mutual-information-metrics branch from 349ceb7 to 26e2064 Compare June 11, 2021 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.