Skip to content

Conversation

Xenoamor
Copy link

@Xenoamor Xenoamor commented Sep 30, 2025

Pull Request Description

Currently the icp_val is clamped to 64. This is 7 bits and bleeds into the "Must be 0" section violating the datasheet, this change clamps it correctly to 63

image

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the Coding style guidelines
  • I have complied with the Submission Checklist
  • I have performed a self-review of the changes
  • I have commented my code, at least hard-to-understand parts
  • I have build all projects affected by the changes in this PR
  • I have tested in hardware affected projects, at the relevant boards
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe etc), if applies

@CLAassistant
Copy link

CLAassistant commented Sep 30, 2025

CLA assistant check
All committers have signed the CLA.

@Xenoamor Xenoamor changed the title Fix icp_val exceeding 6 bits in ad9361.c drivers: rf-transceiver:ad9361: Fix icp_val exceeding 6 bits in ad9361.c Sep 30, 2025
@Xenoamor Xenoamor changed the title drivers: rf-transceiver:ad9361: Fix icp_val exceeding 6 bits in ad9361.c drivers: rf-transceiver:ad9361: fix icp_val exceeding 6 bits Sep 30, 2025
@Xenoamor Xenoamor changed the title drivers: rf-transceiver:ad9361: fix icp_val exceeding 6 bits drivers: rf-transceiver: ad9361: fix icp_val exceeding 6 bits Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants