Skip to content

Conversation

AAndrisa
Copy link
Contributor

@AAndrisa AAndrisa commented Oct 6, 2025

Pull Request Description

If the documentation label is set to the opened PR then we skip the projects building jobs.
The condition on the jobs is: if the build reason is different from PR build anyway, and if it's a PR, build just if the documentation label is not found.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the Coding style guidelines
  • I have complied with the Submission Checklist
  • I have performed a self-review of the changes
  • I have commented my code, at least hard-to-understand parts
  • I have build all projects affected by the changes in this PR
  • I have tested in hardware affected projects, at the relevant boards
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe etc), if applies

If the documentation label is set to the opened PR then we skip the
projects building jobs.
The condition on the jobs is: if the build reason is different from PR
build anyway, and if it's a PR, build just if the documentation label is
not found.

Signed-off-by: Andreea Andrisan <[email protected]>
Copy link
Contributor

@amiclaus amiclaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure how useful this approach is, taking into consideration that people (especially the external contributers) don't add labels to the PRs (or add the labels after the PR is opened).

I'd rather check if the PR contains only changes in the doc folder or README.rst files and skip the unnecessary builds.

Copy link
Contributor

@amiclaus amiclaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will definitely make sense if we have an automated procedure of adding tags to the PRs as it is for example on zephyr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants