-
Notifications
You must be signed in to change notification settings - Fork 889
Laravel 6.0 compatibility #625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
khairilanuar
commented
Aug 30, 2019
- replace all deprecated laravel 5.x str_* to Str helper static call
* replace all deprecated laravel 5.x str_* to Str helper static call
@khairilanuar This changes is compatibility with other versions of Laravel or some 6? |
Hi @eullercdr Laravel has dropped String & Array helpers in Laravel version 6.0. you can see it here: https://laravel.com/docs/6.0/upgrade#helpers . We are urged to use However if you merged this fix I'm afraid it will break for Lumen users, but without this fix generator command will not work in Laravel 6.0 |
* replace all deprecated laravel 5.x array_* to Arr helper static call
@eullercdr yes it is deprecated, it will remove in laravel 6 |
@khairilanuar @eullercdr , they can install this https://github.com/laravel/helpers if this will need, after merging this |
just to make sure we do not use deprecated functions |
@eullercdr can we have this? because laravel 6 alread released, this helper functions already remove also thank you |
I have an issue with installing this package in the Laravel 6 project because |
maybe the solution is make a PR to make validation optinal in this package |
This can break projects which use this validation. |
@eullercdr Laravel 5.7 and higher version, you can tag with version 4 to keep old compatibility |
Dears sorry for delay. I am very busy days. |
Hi @kuzik , @eullercdr @Yannik-Slym I am sorry for the delay, it is a long holiday here in my country. Please have a look at my fork at https://github.com/khairilanuar/laravel-repositoryto get some idea |