Skip to content

Conversation

khairilanuar
Copy link
Contributor

  • replace all deprecated laravel 5.x str_* to Str helper static call

* replace all deprecated laravel 5.x str_* to Str helper static call
@eullercdr
Copy link
Collaborator

@khairilanuar This changes is compatibility with other versions of Laravel or some 6?

@khairilanuar
Copy link
Contributor Author

Hi @eullercdr Laravel has dropped String & Array helpers in Laravel version 6.0. you can see it here: https://laravel.com/docs/6.0/upgrade#helpers . We are urged to use Str:: and Arr:: directly instead.

However if you merged this fix I'm afraid it will break for Lumen users, but without this fix generator command will not work in Laravel 6.0

* replace all deprecated laravel 5.x array_* to Arr helper static call
@lloricode
Copy link
Contributor

@eullercdr yes it is deprecated, it will remove in laravel 6

https://laravel.com/docs/6.0/upgrade#helpers

@lloricode
Copy link
Contributor

@khairilanuar @eullercdr , they can install this https://github.com/laravel/helpers if this will need, after merging this

@lloricode
Copy link
Contributor

just to make sure we do not use deprecated functions

@lloricode
Copy link
Contributor

@eullercdr can we have this? because laravel 6 alread released, this helper functions already remove also

thank you

@kuzik
Copy link

kuzik commented Sep 6, 2019

I have an issue with installing this package in the Laravel 6 project because prettus/laravel-validation still require illuminate/support: ~5.4
Are you able to install this package in your L6 project?

@lloricode
Copy link
Contributor

maybe the solution is make a PR to make validation optinal in this package

@kuzik
Copy link

kuzik commented Sep 6, 2019

This can break projects which use this validation. prettus/laravel-validation will support Laravel6 soon maybe it can be better to wait for approve this PR andersao/laravel-validator#35

@YannikFirre
Copy link

YannikFirre commented Sep 6, 2019

@khairilanuar This changes is compatibility with other versions of Laravel or some 6?

@eullercdr Laravel 5.7 and higher version, you can tag with version 4 to keep old compatibility

@eullercdr
Copy link
Collaborator

Dears sorry for delay. I am very busy days.
I'll have a look as soon as possible!

@khairilanuar
Copy link
Contributor Author

Hi @kuzik , @eullercdr @Yannik-Slym I am sorry for the delay, it is a long holiday here in my country.
I also forked prettus/laravel-validation and have it compatible with Laravel 6. I can submit pull request for prettus/laravel-validation to make it compatible with L6.

Please have a look at my fork at https://github.com/khairilanuar/laravel-repositoryto get some idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants