Fix depwarns and wrong use of reinterpret #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
reviewed
May 18, 2017
| a::Vector{UInt8} | ||
| end | ||
| # unsafe | ||
| @inline Base.getindex{T}(a::UnalignedVector{T}, i) = unsafe_load(Ptr{T}(pointer(a.a)), i) |
There was a problem hiding this comment.
@boundscheck Base.checkbounds(a.a, i) ?
Contributor
Author
There was a problem hiding this comment.
The only limited user below is in @inbounds so I didn't bother...
Contributor
Author
There was a problem hiding this comment.
(Also because this package still support 0.4, which doesn't support the new bounds check elision yet?)
tkelman
reviewed
Jul 18, 2017
| julia 0.4 | ||
| ArgParse | ||
| Compat 0.16.0 | ||
| Compat 0.18.0 |
There was a problem hiding this comment.
this should only be 0.17 right, since none of the aliases are parametric?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref JuliaLang/julia#21831